Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases of the lidar sensor becoming unpowered during operation #119

Conversation

tombrodie
Copy link

Related Issues & PRs

Summary of Changes

  • Introduces a new launch argument retry_configuration (default false) which, when true, will continue to attempt to configure the lidar sensor if the sensor is uncontactable on initialisation instead of the current behaviour of the code crashing. Additionally, if the sensor becomes uncontactable during operation, this branch periodically attempts to re-establish a connection to the sensor using the configuration provided on initialisation.

Validation

  • Tested with an OS0 lidar sensor for the cases of:
  1. A powered sensor on code launch
  2. An unpowered sensor on code launch
  3. A powered sensor on code launch, then made unpowered, then made powered again

@Samahu
Copy link
Contributor

Samahu commented May 3, 2023

@tombrodie thanks for your contribution, I will try to take a look at your PR towards the end of the last of the month.

@Samahu
Copy link
Contributor

Samahu commented Aug 31, 2024

included/resolved by #362

@Samahu Samahu closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants